-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for illumos target #1295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a bump in libc
version? I can image there will be changes required to that crate as well.
Also we would need CI support, running at least cargo check
, for Illumos to be supported by Mio.
5947faf
to
5a3a3bf
Compare
Yep, fixed.
I'm waiting on the PR to add support for the target into rustc right now. I have tested locally with a toolchain built from that to ensure that the results compile (and pass at least as many tests as the |
5a3a3bf
to
c2bb0e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think this is blocked on #1301 with the CI waiting for ever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good once it is rebased.
c2bb0e8
to
c8f7f26
Compare
Rebased, with the conflicts addressed. |
@pfmooney thanks! |
As the master branch counterpart to the 0.6.x PR (#1294), this adds support for the Solaris-like (but distinct)
illumos
target. When support is merged into rust, it would be nice for mio to be immediately usable.