Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for illumos target #1295

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

pfmooney
Copy link
Contributor

As the master branch counterpart to the 0.6.x PR (#1294), this adds support for the Solaris-like (but distinct) illumos target. When support is merged into rust, it would be nice for mio to be immediately usable.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a bump in libc version? I can image there will be changes required to that crate as well.

Also we would need CI support, running at least cargo check, for Illumos to be supported by Mio.

src/sys/unix/selector/epoll.rs Outdated Show resolved Hide resolved
src/sys/unix/net.rs Outdated Show resolved Hide resolved
@pfmooney pfmooney force-pushed the illumos-target-0.7 branch 2 times, most recently from 5947faf to 5a3a3bf Compare April 15, 2020 14:09
@pfmooney
Copy link
Contributor Author

Does this need a bump in libc version? I can image there will be changes required to that crate as well.

Yep, fixed.

Also we would need CI support, running at least cargo check, for Illumos to be supported by Mio.

I'm waiting on the PR to add support for the target into rustc right now. I have tested locally with a toolchain built from that to ensure that the results compile (and pass at least as many tests as the x86_64-sun-solaris target does). Considering that the illumos triple is going to effectively subsume many (most?) instances of the solaris one, we wanted to get ahead of it so popular crates like mio will be supported ASAP once support shows up in nightly builds.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is blocked on #1301 with the CI waiting for ever.

Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good once it is rebased.

@pfmooney pfmooney force-pushed the illumos-target-0.7 branch from c2bb0e8 to c8f7f26 Compare April 26, 2020 17:34
@pfmooney
Copy link
Contributor Author

This looks good once it is rebased.

Rebased, with the conflicts addressed.

@Thomasdezeeuw Thomasdezeeuw merged commit 976f235 into tokio-rs:master Apr 26, 2020
@Thomasdezeeuw
Copy link
Collaborator

@pfmooney thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants