-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement vectored I/O for TcpStream #1016
Conversation
I want to take the same approach for #977. |
@carllerche What do you think about it? |
Well 1.36 was just released, so this doesn't have to work with nightly features any more. But this can still apply to |
@Thomasdezeeuw my take is, let’s target a future rust release and use nightly until then. I just prefer avoiding the feature flag. I expect we won’t cut 0.7 until at least async / await is on stable. |
Basically I’m fine with this change, just without the feature flag :-) |
@carllerche Sounds good to me. Could you change the CI to use the nightly compiler only? I haven't figured out the Azure pipeline stuff. |
13641a7
to
fb67700
Compare
I've forced push changes to just implemented {read, write}_vectored. But this will fail the CI on old stable compilers. |
We can probably just switch stable to nightly in Ci for now. That is what we do for Tokio. |
Looking at another build from earlier today (https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=1324&view=logs), it seems 1.36 is only used for macOS builds, other OSes are still on 1.35. I'll wait off on a rebase when the other OSes also use 1.36. |
@Thomasdezeeuw this comments explains how to get CI on the latest Rust. |
Pr #1028 fixes the problems with the CI, so I'll wait for that to be merged before rebasing this. |
Only used in testing.
Now implemented as {read, write}_vectored.
d46fc94
to
2912772
Compare
I've rebased on master, @carllerche can you give this a final look over to see if I didn't mess anything up while merging? |
Great, both min Rust version and Windows fails because they both use 1.35. |
b66d566
to
25efca8
Compare
@carllerche I know you've said your not a fan of this approach but at least we can start using more nightly features on the crate without breaking the stable builds this way.
TODO:
TcpStream::{read_bufs, write_bufs}
.IoVec
so it shouldn't be too hard.iovec
dependency.Updates #957.