Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove authors fields from Cargo.tomls #168

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Remove authors fields from Cargo.tomls #168

merged 1 commit into from
Sep 30, 2021

Conversation

lunacookies
Copy link
Contributor

The authors field has been effectively soft-deprecated, as it is no longer required, shown on crates.io or docs.rs, and crates created with cargo new no longer automatically create the authors field. Keeping or removing the field is of course a matter of taste, but I thought that, since it doesn’t have any effect anymore, it might be easier to just remove it instead of updating it over time as contributors come and go.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of the console CLI app, the authors field will auto-populate the help text generated by clap, which might be worth keeping, especially in the case that the CLI is ever packaged by distros. But, we can add authors to the help text using an attribute, as well, so it's not critical that we keep it in the cargo metadata.

This is fine with me!

@hawkw hawkw merged commit 3d80c4b into tokio-rs:main Sep 30, 2021
@lunacookies lunacookies deleted the remove-authors branch October 1, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants