Refactor TestClient usage
#3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the somewhat arcane `include!(concat!(...))` construct in the `axum-extra` crate, which some IDEs (JetBrains) don't like particularly much...
This is where the extractor is implemented, so it would make sense to colocate the tests there too.
|
I like the idea! Will review later. |
jplatte
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the
TestClientstruct fromaxumis shared withaxum-extraand also makes it available toaxum-core.This change avoids the somewhat arcane
include!(concat!(...))construct in theaxum-extracrate, which some IDEs (JetBrains) don't like particularly much. The alternative proposed by this PR is a__privatefeature, similar to the one inaxum-macros, that enables the public export of theTestClientstruct. Theaxumdev-dependencies in the other two crates then enable that feature, so that it can be used in their test suites.This enables us to move the
request_partstests intoaxum-core, next to the implementation that they are testing.