Remove broken rest-grpc-multiplex example
#3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example has not been updated to hyper v1 for a year and requires every developer to have `protoc` installed on their machine to be able to run `cargo build --workspace`. Both of these points combined IMHO shift the tradeoff enough to it not being valuable enough to keep the broken example around.
well, I just discovered #2825, so that point is not as strong as I thought. still, the |
|
I agree with this. The fact that the upgrade PR has been lingering for quite a while is IMO another reason to just remove it. It's probably better to have an example like this in the tonic repo. |
jplatte
approved these changes
Dec 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example has not been updated to hyper v1 for a year and requires every developer to have
protocinstalled on their machine to be able to runcargo build --workspace. Both of these points combined IMHO shift the tradeoff enough to it not being valuable enough to keep the broken example around.