Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example integration test for SSE #2465

Merged
merged 7 commits into from
Dec 30, 2023
Merged

Add an example integration test for SSE #2465

merged 7 commits into from
Dec 30, 2023

Conversation

chenhunghan
Copy link
Contributor

@chenhunghan chenhunghan commented Dec 30, 2023 •
edited
Loading

Motivation

The SSE example was missing a test, would be nice to have one.

Solution

This PR adds an example for integration test.

  • Adding the integration test requiring some minor refactoring of the example, this PR moves the create of app into a separate app().
  • Add dev-dependencies: reqwest/reqwest-eventsource/eventsource-stream that were used in tests.

@chenhunghan
Use .take(1) in tests
9cc61f1 
Signed-off-by: Hung-Han (Henry) Chen <[email protected]>
@chenhunghan
Format issues
6d40dd4 
Signed-off-by: Hung-Han (Henry) Chen <[email protected]>
davidpdrsn
davidpdrsn reviewed Dec 30, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new nits but otherwise looks good!

chenhunghan and others added 3 commits December 30, 2023 17:54
@chenhunghan @davidpdrsn
Update examples/sse/src/main.rs
911f51a 
Co-authored-by: David Pedersen <[email protected]>
@chenhunghan
Format issues
4be4c13 
Signed-off-by: Hung-Han (Henry) Chen <[email protected]>
@chenhunghan @davidpdrsn
Update examples/sse/src/main.rs
4a9a6e7 
Co-authored-by: David Pedersen <[email protected]>
davidpdrsn
davidpdrsn approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn merged commit c340415 into tokio-rs:main Dec 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenhunghan @davidpdrsn