Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce hyper dependency #2350

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Reduce hyper dependency #2350

merged 3 commits into from
Nov 24, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Nov 24, 2023

Motivation

Reduces hyper dependency.

Solution

Depends on hyper only when it is used.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are implicitly creating a hyper feature by not using dep: syntax for the feature dependency. I don't think that is what we want, right? I also wonder if any of the features that enable hyper + one of its features should be made to not enable hyper. Would have to be reviewed one by one.

@tottoto
Copy link
Contributor Author

tottoto commented Nov 24, 2023

Fixed the implicit feature, caused by missing dep: prefix.

@tottoto
Copy link
Contributor Author

tottoto commented Nov 24, 2023

The mix use of dep:crate and crate/feature seems to need to be waited until Rust 1.71. So changing hyper optional dependency does not seem possible at the moment.

@jplatte
Copy link
Member

jplatte commented Nov 24, 2023

Yes, "dep:hyper" and "hyper/foo" can't be mixed in older versions but you can just write "dep:hyper", "hyper?/foo", which has the same meaning as "hyper/foo".

@tottoto
Copy link
Contributor Author

tottoto commented Nov 24, 2023

Thanks. Fixed to use the workaround.

@jplatte jplatte merged commit a9ac524 into tokio-rs:main Nov 24, 2023
18 checks passed
@tottoto tottoto deleted the hyper-dependency branch November 24, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants