Remove B type param: axum-core
#1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
approved these changes
Feb 20, 2023
| /// # async { | ||
| /// # hyper::Server::bind(&"".parse().unwrap()).serve(app.into_make_service()).await.unwrap(); | ||
| /// # }; | ||
| /// # let _: Router = app; |
There was a problem hiding this comment.
I guess that answers my question 😄
There was a problem hiding this comment.
Hehe yes. I ran a quick search and replace to catch at least some of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step in removing the
Btype param as outlined in #1751. This PR updates axum-core.The changes are entirely mechanical. Stop using
Request<B>and useRequest<axum_core::body::Body>instead.I think a
type Request<B = axum_core::body::Body> = http::Request<B>alias would also be nice, similarly to what we have forResponse. I'll probably add that when #1751 is merged.