-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style variable decimal import #3241
Conversation
🦋 Changeset detectedLatest commit: 2af11a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Commit SHA:94590a9c22e8a4bd3b4013b450926bfd27183028 Test coverage results 🧪
|
Commit SHA:94590a9c22e8a4bd3b4013b450926bfd27183028 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changeset and a test would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Why does this PR exist?
Fixes #2706
Fixes #3213
What does this pull request do?
This PR addresses the issue when we import a style with text size or a Number variable with decimal values.
The import of a number like 33.6 is reflected as 33.599... in the corresponding token in the plugin
Also, addresses the number variables imported as NaNrem when the baseFontSize in ui Setting is blank.
Testing this change
Additional Notes (if any)