update isSameCredentials check to prefer internalId when available #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f75c8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
|
|
|
Commit SHA:a962193ceaa2af78592a6b380bae8413cc0f865d Test coverage results 🧪
|
akshay-gupta7
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Closes #3069
Our check for if a sync provider is active was missing logic to compare the unique
internalIdwhen available for some sync providers. This PR elevates that to always check for those, if present. Also updates tests.Note: The
internalIdwas something that we added 2 years back now or so. So we should in most cases have it, it might just be the case for really old examples that we dont have it.What does this pull request do?
Testing this change
Add a Studio sync provider with two different API keys.
Old version = shows up twice
New version = active state shown properly