Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate display studio sync #3171

Closed
wants to merge 7 commits into from
Closed

Fix duplicate display studio sync #3171

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
abac5ba
add a delay timeout when user clicks on Save
akshay-gupta7 Oct 10, 2024
6fd71f2
formatting
akshay-gupta7 Oct 10, 2024
8811070
add changeset
akshay-gupta7 Oct 10, 2024
3276408
revert delayed form submission in studio sync form
akshay-gupta7 Oct 11, 2024
7435e66
add check to remove duplicate sync providers
akshay-gupta7 Oct 11, 2024
5545e56
formatting
akshay-gupta7 Oct 11, 2024
015ff32
remove debug statement
akshay-gupta7 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-ants-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tokens-studio/figma-plugin": patch
---

fixed an issue where the studio sync provider was mistakenly displayed twice upon setting up the connection
34 changes: 21 additions & 13 deletions packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default function TokensStudioForm({
const syncGuideUrl = 'tokens-studio';
const [isMasked, setIsMasked] = React.useState(true);
const [showTeaser, setShowTeaser] = React.useState(true);
const [isLoading, setIsLoading] = React.useState(false);

const toggleMask = React.useCallback(() => {
setIsMasked((prev) => !prev);
Expand All @@ -57,7 +58,13 @@ export default function TokensStudioForm({
...validationResult.data,
internalId: validationResult.data.internalId || generateId(24),
} as ValidatedFormValues;
setIsLoading(true);

onSubmit(formFields);

setTimeout(() => {
setIsLoading(false);
}, 5000);
}
},
[values, onSubmit],
Expand All @@ -73,21 +80,22 @@ export default function TokensStudioForm({
setShowTeaser(false);
}, []);

return showTeaser ? (
<Stack direction="column" align="start" gap={5}>
<StyledTokensStudioWord />
<Stack direction="column" gap={3}>
<Heading size="large">A dedicated design tokens management platform</Heading>
<Box>We are working a dedicated design tokens management platform built on our powerful node-based graph engine including plug and play token transformation - suitable for enterprises! Still in early access, sign up for the waitlist!</Box>
<Link href="https://tokens.studio/studio" target="_blank" rel="noreferrer">Learn more</Link>
</Stack>
<Button onClick={handleDismissTeaser}>Already got access?</Button>
return showTeaser ? (
<Stack direction="column" align="start" gap={5}>
<StyledTokensStudioWord />
<Stack direction="column" gap={3}>
<Heading size="large">A dedicated design tokens management platform</Heading>
<Box>We are working a dedicated design tokens management platform built on our powerful node-based graph engine including plug and play token transformation - suitable for enterprises! Still in early access, sign up for the waitlist!</Box>
<Link href="https://tokens.studio/studio" target="_blank" rel="noreferrer">Learn more</Link>
</Stack>
):(
<Button onClick={handleDismissTeaser}>Already got access?</Button>
</Stack>
) : (
<form onSubmit={handleSubmit}>
<Stack direction="column" gap={5}>
<Text muted>
{t('providers.tokensstudio.descriptionFirstPart')}{' '}
<Text muted>
{t('providers.tokensstudio.descriptionFirstPart')}
{' '}
<Link
href="https://q2gsw2tok1e.typeform.com/to/pJCwLVh2?typeform-source=tokens.studio"
target="_blank"
Expand Down Expand Up @@ -138,7 +146,7 @@ export default function TokensStudioForm({
<Button variant="secondary" onClick={onCancel}>
{t('cancel')}
</Button>
<Button variant="primary" type="submit" disabled={!values.secret && !values.name}>
<Button variant="primary" type="submit" disabled={isLoading || (!values.secret && !values.name)}>
{t('save')}
</Button>
</Stack>
Expand Down
Loading