Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bitbucket empty sets #3152

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Fix bitbucket empty sets #3152

merged 3 commits into from
Sep 25, 2024

Conversation

akshay-gupta7
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 commented Sep 23, 2024

Description

Fixes #3117

Description

Fixes a bug with Bitbucket sync issue where a deleted set's json still reflects in the repo.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How to test this

  • Sync Tokens with Bitbucket
  • Delete a token set in the plugin
  • Sync again with bitbucket
  • The json file of the deleted set should now be removed.

Screenshots or video (if necessary):

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 5f60141

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 23, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Commit SHA:492a6764855fcea6fe3055288631d562f4d933a0

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-bitbucket-empty-sets 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 67.9 (-0.01) 58.5 (-0.05) 64.63 (-0.06) 68.29 (-0.01)
🔴 packages/tokens-studio-for-figma/src/storage/BitbucketTokenStorage.ts 62.22 (-1.41) 55.1 (-8.31) 59.09 (-9.33) 62.06 (-1.45)

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Commit SHA:492a6764855fcea6fe3055288631d562f4d933a0
Current PR reduces the test coverage percentage by 1 for some tests

@akshay-gupta7 akshay-gupta7 marked this pull request as ready for review September 24, 2024 13:07
Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@akshay-gupta7 akshay-gupta7 merged commit fe94d6a into main Sep 25, 2024
10 of 11 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix-bitbucket-empty-sets branch September 25, 2024 06:23
@akshay-gupta7 akshay-gupta7 self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted set still visible after push to Bitbucket
2 participants