Fix variable creation issue #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b538dc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| successfullyAppliedVariable = true; | ||
| } catch (e) { | ||
| // eslint-disable-next-line no-console | ||
| console.error('unable to apply variable', key, variableToApply, e); |
Check warning
Code scanning / ESLint
disallow the use of `console` Warning
|
Commit SHA:c64bfb16c45192973694d102cf2e6d1ce303d2be Test coverage results 🧪
|
|
Commit SHA:c64bfb16c45192973694d102cf2e6d1ce303d2be |
akshay-gupta7
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves 2 issues:
Font weight issues
When users were using numerical font weights in their typography tokens, and they had a varaible reference to both the family and the numerical weight, we didnt properly create styles. This only occurred if the font family and weight wasnt covered by our font weight fallbacks (e.g. use
Comic Sans MSwith a weight of600)This is due to Figma requiring us to
loadFontAsyncusing the string version of the weight ("Bold"). However, all we know is the numerical weight ("600"). We can not realistically know the string version. So this PR changes this to rather load all font weights of the current font family.Color token issues with modifiers when creating color styles
If users were using a color token that had a pure reference such as
{colors.gray.500}and a modifier, and the colors.gray.500 token existed as a variable, previously we would use a variable reference. We now check if the token is using a modifier, and if yes, we do not go an create a variable reference.This issue ONLY occurred if the Variable exists as a reference and the user is trying to create color styles using those variable reference
CleanShot.2024-09-06.at.09.22.39.mp4
https://github.com/user-attachments/assets/66ef0c75-e144-4113-9c47-66c8186e6b91
example.json