-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix import of variables speed #3114
Conversation
🦋 Changeset detectedLatest commit: 7197f91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
tested and this improves the import speed a lot |
Here's the code health analysis summary for commits Analysis Summary
|
Commit SHA:7d5ef98e9324869ba4b739e0f86184930f451069 Test coverage results 🧪
|
Commit SHA:7d5ef98e9324869ba4b739e0f86184930f451069 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; tested with an import, then updating variables and importing again. Editing existing tokens seems to work too.
Importing variables with the production plugin hangs the plugin/Figma for about ten seconds, import happens in under a second now 💯 🎉
Why does this PR exist?
Fixes speed of variable creation by ... perceived 100x
Fixes #3122
What does this pull request do?
Properly import variables by not doing it one by one but rather in one swift swoop
Testing this change
Import variables into tokens... also test if you can update existing ones properly as expected
Additional Notes (if any)