Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ADO single and multi file tests #3096

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

cuserox
Copy link
Contributor

@cuserox cuserox commented Aug 21, 2024

Why does this PR exist?

Closes #3085

What does this pull request do?

Changes to the way that ADO works meant that the fetch mocks had to be updated to test the functionality correctly

Testing this change

Run the tests (or see them in the pipeline) - see that ADOTokenStorageTest.ts

@cuserox cuserox added bug Something isn't working sync azure devops ado plugin v2 variables, UI, WTCG format, Bitbucket labels Aug 21, 2024
@cuserox cuserox self-assigned this Aug 21, 2024
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 8206c96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 21, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Commit SHA:4648b18903b2a8eed43fae531aa7ada6d7f353af

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix/3085-update-ado-related-tests 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.91 (0.27) 58.59 (0.19) 64.56 (0.23) 68.31 (0.26)
🟢 packages/tokens-studio-for-figma/src/storage/ADOTokenStorage.ts 81.74 (26.19) 63.52 (18.82) 80.64 (22.58) 84.03 (26.05)

Copy link
Contributor

@macintoshhelper macintoshhelper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment re changeset for tests, not sure if this would be (or whether it should be) surfaced for the 2.0.2 changelog

@cuserox cuserox merged commit 8dfc3eb into main Aug 22, 2024
10 checks passed
@cuserox cuserox deleted the fix/3085-update-ado-related-tests branch August 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket sync azure devops ado
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests related to ADO
2 participants