Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox UI for duplicate resolve modal #3079

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

macintoshhelper
Copy link
Contributor

@macintoshhelper macintoshhelper commented Aug 16, 2024

Why does this PR exist?

Fixes #3068

What does this pull request do?

  • Fixes checkbox for max width value previews.

Testing this change

  • Use this tokens JSON
{
"a": {
    "test": {
      "$type": "color",
      "$value": "#0aa"
    }
  },
  "a-copy": {
    "test": {
      "$type": "color",
      "$value": "linear-gradient(180deg, {colors.teal.800}, {colors.teal.800}, {colors.teal.800}, #0fa, {colors.teal.800} , #0fa 100%)"
    }
  }
}

Change const error ... in DuplicateTokenGroupModal to this (might need to set some types to any for the build to pass):

const error: any = useMemo(() => null, [isOpen, activeTokenSet, newName, oldName, selectedTokenSets, tokens, type]);
  • Duplicate the group a-copy to a

  • Open the duplicate resolve modal button in the footer.

  • Verify that the radio checkbox isn't stretched

Additional Notes (if any)

image

Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: 81b50a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 16, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Aug 16, 2024

Commit SHA:a0daada71b8ddc1ea33a7bceba29ee05ec31d6eb
No changes to code coverage between the base branch and the head branch

Copy link
Contributor

@cuserox cuserox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

@macintoshhelper macintoshhelper merged commit 22018a9 into main Aug 22, 2024
8 checks passed
@macintoshhelper macintoshhelper deleted the fix/3068-radio-button-resolve-modal branch August 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual bug with radio buttons in Resolve modal
2 participants