Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken UI issue #3074

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fixes broken UI issue #3074

merged 1 commit into from
Aug 15, 2024

Conversation

six7
Copy link
Collaborator

@six7 six7 commented Aug 15, 2024

Why does this PR exist?

Closes #3073

We didnt await setupReplay before, which seems to have caused some issues initializing our CSS styles.

What does this pull request do?

Adds a 2 second timeout to session recording.

Testing this change

Enable remote storage, enable session recording. Restart plugin. All should look good. With 2.0 prod it looks broken.

Additional Notes (if any)

Before:

CleanShot 2024-08-15 at 10 29 35@2x

After:

CleanShot 2024-08-15 at 10 27 25@2x

Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 8735151

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

Commit SHA:a7573c60631f2c9ec7e4a081c996907b2ab94669

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix/ui-broken-sentry 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 67.96 (-0.02) 58.7 (0) 64.75 (-0.02) 68.35 (-0.02)
🔴 packages/tokens-studio-for-figma/src/app/sentry.ts 36.84 (-6.91) 42.85 (0) 0 (0) 36.84 (-6.91)

Copy link
Contributor

Commit SHA:a7573c60631f2c9ec7e4a081c996907b2ab94669
Current PR reduces the test coverage percentage by 1 for some tests

@rbosker
Copy link
Collaborator

rbosker commented Aug 15, 2024

this fixes the issue for me

@six7 six7 merged commit 3405929 into main Aug 15, 2024
7 of 8 checks passed
@six7 six7 deleted the fix/ui-broken-sentry branch August 15, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issues in the plugin when enabling record session for bugfixing
3 participants