Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate shortcuts #3061

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+1,383 −30
Open

Fix duplicate shortcuts #3061

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90906fd
Browser plugin preview (#2748)
macintoshhelper Jul 26, 2024
deb22b3
Wrap Shortcut registration in PushDialog in a useEffect hook
akshay-gupta7 Aug 5, 2024
cc25cf8
remove debug statement
akshay-gupta7 Aug 11, 2024
2c7ff48
remove unused import
akshay-gupta7 Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wrap Shortcut registration in PushDialog in a useEffect hook
@akshay-gupta7
akshay-gupta7 committed Aug 5, 2024
commit deb22b35f608d2618f6409566ef809a2e3dea5ae
7 changes: 6 additions & 1 deletion packages/tokens-studio-for-figma/src/app/components/PushDialog.tsx
View file
Original file line number Diff line number Diff line change
@@ -105,7 +105,12 @@ function PushDialog() {
[handlePushChanges, showPushDialog],
);

useShortcut(['Enter'], handleSaveShortcut);
React.useEffect(() => {
if (showPushDialog?.state === 'initial') {
useShortcut(['Enter'], handleSaveShortcut);
console.log("Registered");
}
}, [showPushDialog, handleSaveShortcut]);

switch (showPushDialog?.state) {
case 'dtcgconversion':