Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add network access to manifest #2203

Merged
merged 1 commit into from
Aug 30, 2023
Merged

add network access to manifest #2203

merged 1 commit into from
Aug 30, 2023

Conversation

six7
Copy link
Collaborator

@six7 six7 commented Aug 30, 2023

fixes https://github.com/tokens-studio/planning/issues/81

adds an entry to manifest.json for networkAccess of the plugin

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

⚠️ No Changeset found

Latest commit: f8fae5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Add network access to manifest
  • 📝 PR summary: This PR adds an entry to the manifest.json file to allow network access for the plugin. It includes the allowed domains and a reasoning for the network access.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • 🔒 Security concerns: No security concerns found

PR Feedback

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@six7 six7 marked this pull request as ready for review August 30, 2023 12:06
@six7 six7 merged commit 900b4fc into main Aug 30, 2023
6 checks passed
@github-actions
Copy link
Contributor

Commit SHA:17d90c5233ee4fc6a7692e82fa0a22b455e42c00

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: feat/introduce-network-access 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 68.3 (0.02) 59.43 (0) 66.47 (0.04) 68.55 (0.02)
🟢 src/app/components/ConfirmDialog.tsx 80 (3.81) 70.83 (4.17) 81.25 (2.68) 79.48 (3.81)
🔴 src/app/components/EditTokenForm.tsx 47.72 (-0.03) 28.08 (0) 38.63 (0) 48.52 (-0.01)
🟢 src/app/components/Input.tsx 78.94 (1.17) 82.92 (0) 75 (8.34) 78.94 (1.17)
🔴 src/app/components/TokenTooltip/TokenTooltip.tsx 75 (-5) 75 (-8.33) 100 (0) 75 (-5)
🔴 src/app/store/useTokens.tsx 72.79 (-0.2) 55 (0) 69.56 (0) 72.58 (-0.22)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant