Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1522 when applying border tokens we always apply color as a hex instead of style when available #1531

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/plugin/extractColorInBorderTokenForAlias.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { MapValuesToTokensResult } from '@/types';
import { NodeTokenRefMap } from '@/types/NodeTokenRefMap';
import { AnyTokenList } from '@/types/tokens';

export function extractColorInBorderTokenForAlias(tokens: Map<string, AnyTokenList[number]>, values: NodeTokenRefMap, borderToken: string): MapValuesToTokensResult {
const resolvedToken = tokens.get(borderToken);
if (resolvedToken?.rawValue && typeof resolvedToken.rawValue === 'object' && 'color' in resolvedToken.rawValue && resolvedToken.rawValue.color) {
const { color } = resolvedToken.rawValue;
const { borderColor } = values;
let colorTokenName = color;
if (String(color).startsWith('$')) colorTokenName = String(color).slice(1, String(color).length);
if (String(color).startsWith('{')) colorTokenName = String(color).slice(1, String(color).length - 1);
values = { ...values, ...(borderColor ? { } : { borderColor: String(colorTokenName) }) };
}
return values;
}
30 changes: 30 additions & 0 deletions src/plugin/node.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
destructureToken, mapValuesToTokens, returnValueToLookFor, saveStorageType, saveOnboardingExplainerSets, saveOnboardingExplainerInspect, saveOnboardingExplainerSyncProviders,
} from './node';
import getOnboardingExplainer from '@/utils/getOnboardingExplainer';
import { TokenTypes } from '@/constants/TokenTypes';

const singleShadowToken = {
type: 'boxShadow',
Expand Down Expand Up @@ -49,6 +50,15 @@ const multipleShadowToken = {
],
};

const borderToken = {
type: TokenTypes.BORDER,
value: {
color: '#ff0000',
width: '12px',
type: 'solid',
},
};

const tokens = new Map([
['global.colors.blue',
{
Expand Down Expand Up @@ -163,6 +173,21 @@ const mappedTokens = [
{
boxShadow: multipleShadowToken.value,
},
{
border: borderToken.value,
},
{
borderTop: borderToken.value,
},
{
borderRight: borderToken.value,
},
{
borderLeft: borderToken.value,
},
{
borderBottom: borderToken.value,
},
];

const applyProperties = [
Expand All @@ -173,6 +198,11 @@ const applyProperties = [
{ boxShadow: multipleShadowToken.value },
{ boxShadow: singleShadowToken.value },
{ boxShadow: multipleShadowToken.value },
{ border: borderToken.value, borderColor: '#ff0000' },
{ borderTop: borderToken.value, borderColor: '#ff0000' },
{ borderRight: borderToken.value, borderColor: '#ff0000' },
{ borderLeft: borderToken.value, borderColor: '#ff0000' },
{ borderBottom: borderToken.value, borderColor: '#ff0000' },
];

describe('mapValuesToTokens', () => {
Expand Down
35 changes: 26 additions & 9 deletions src/plugin/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
import { AsyncMessageChannel } from '@/AsyncMessageChannel';
import { AsyncMessageTypes } from '@/types/AsyncMessages';
import { updatePluginData } from './pluginData';
import { extractColorInBorderTokenForAlias } from './extractColorInBorderTokenForAlias';

// @TODO fix typings

Expand Down Expand Up @@ -149,6 +150,18 @@ export function destructureToken(values: MapValuesToTokensResult): MapValuesToTo
if (values && values.border && typeof values.border === 'object' && 'color' in values.border && values.border.color) {
values = { ...values, ...(values.borderColor ? { } : { borderColor: values.border.color }) };
}
if (values && values.borderTop && typeof values.borderTop === 'object' && 'color' in values.borderTop && values.borderTop.color) {
values = { ...values, ...(values.borderColor ? { } : { borderColor: values.borderTop.color }) };
}
if (values && values.borderRight && typeof values.borderRight === 'object' && 'color' in values.borderRight && values.borderRight.color) {
values = { ...values, ...(values.borderColor ? { } : { borderColor: values.borderRight.color }) };
}
if (values && values.borderLeft && typeof values.borderLeft === 'object' && 'color' in values.borderLeft && values.borderLeft.color) {
values = { ...values, ...(values.borderColor ? { } : { borderColor: values.borderLeft.color }) };
}
if (values && values.borderBottom && typeof values.borderBottom === 'object' && 'color' in values.borderBottom && values.borderBottom.color) {
values = { ...values, ...(values.borderColor ? { } : { borderColor: values.borderBottom.color }) };
}
if (values && values.composition) {
Object.entries(values.composition).forEach(([property, value]) => {
tokensInCompositionToken[property as CompositionTokenProperty] = value;
Expand All @@ -161,15 +174,19 @@ export function destructureToken(values: MapValuesToTokensResult): MapValuesToTo

export function destructureTokenForAlias(tokens: Map<string, AnyTokenList[number]>, values: NodeTokenRefMap): MapValuesToTokensResult {
if (values && values.border) {
const resolvedToken = tokens.get(values.border);
if (resolvedToken?.rawValue && typeof resolvedToken.rawValue === 'object' && 'color' in resolvedToken.rawValue && resolvedToken.rawValue.color) {
const { color } = resolvedToken.rawValue;
const { borderColor } = values;
let colorTokenName = color;
if (String(color).startsWith('$')) colorTokenName = String(color).slice(1, String(color).length);
if (String(color).startsWith('{')) colorTokenName = String(color).slice(1, String(color).length - 1);
values = { ...values, ...(borderColor ? { } : { borderColor: String(colorTokenName) }) };
}
values = extractColorInBorderTokenForAlias(tokens, values, values.border);
}
if (values && values.borderTop) {
values = extractColorInBorderTokenForAlias(tokens, values, values.borderTop);
}
if (values && values.borderRight) {
values = extractColorInBorderTokenForAlias(tokens, values, values.borderRight);
}
if (values && values.borderLeft) {
values = extractColorInBorderTokenForAlias(tokens, values, values.borderLeft);
}
if (values && values.borderBottom) {
values = extractColorInBorderTokenForAlias(tokens, values, values.borderBottom);
}
if (values && values.composition) {
const resolvedToken = tokens.get(values.composition);
Expand Down