-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1278-120-rc1-renaming-token-groups-causes-them-to-collapse #1281
Merged
six7
merged 3 commits into
next
from
1278-120-rc1-renaming-token-groups-causes-them-to-collapse
Sep 16, 2022
Merged
1278-120-rc1-renaming-token-groups-causes-them-to-collapse #1281
six7
merged 3 commits into
next
from
1278-120-rc1-renaming-token-groups-causes-them-to-collapse
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
swordEdge
changed the title
bug: fix
1278-120-rc1-renaming-token-groups-causes-them-to-collapse
Sep 13, 2022
Commit SHA:c536835e8c6e7137738dbf2f0d61b6d0abeef5ba |
LiamMartens
suggested changes
Sep 15, 2022
@@ -79,6 +79,7 @@ export function TokenGroupHeading({ | |||
}, [duplicateGroup, path, type]); | |||
|
|||
const handleToggleCollapsed = useCallback(() => { | |||
console.log('collapse'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log statement
six7
approved these changes
Sep 16, 2022
SorsOps
deleted the
1278-120-rc1-renaming-token-groups-causes-them-to-collapse
branch
July 6, 2023 11:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming a token group seems to have a strange side-effect: It collapses the token group while renaming.
Expected: Don't collapse groups while renaming
https://www.loom.com/share/eeb6db0d63884bd6b5e1a0be6ad1457e