Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1278-120-rc1-renaming-token-groups-causes-them-to-collapse #1281

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

swordEdge
Copy link
Contributor

Renaming a token group seems to have a strange side-effect: It collapses the token group while renaming.
Expected: Don't collapse groups while renaming
https://www.loom.com/share/eeb6db0d63884bd6b5e1a0be6ad1457e

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
figma-tokens ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 0:09AM (UTC)
ft-storybook ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 0:09AM (UTC)

@swordEdge swordEdge changed the title bug: fix 1278-120-rc1-renaming-token-groups-causes-them-to-collapse Sep 13, 2022
@swordEdge swordEdge linked an issue Sep 13, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

Commit SHA:c536835e8c6e7137738dbf2f0d61b6d0abeef5ba
No changes to code coverage between the base branch and the head branch

@@ -79,6 +79,7 @@ export function TokenGroupHeading({
}, [duplicateGroup, path, type]);

const handleToggleCollapsed = useCallback(() => {
console.log('collapse');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log statement

@six7 six7 merged commit e3d457a into next Sep 16, 2022
@SorsOps SorsOps deleted the 1278-120-rc1-renaming-token-groups-causes-them-to-collapse branch July 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[120-rc1]: Renaming token groups causes them to collapse
4 participants