Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1275-removing-token-sets-sometimes-fails #1280

Merged
merged 3 commits into from
Sep 17, 2022
Merged

1275-removing-token-sets-sometimes-fails #1280

merged 3 commits into from
Sep 17, 2022

Conversation

swordEdge
Copy link
Contributor

@swordEdge swordEdge commented Sep 13, 2022 •
edited
Loading

Sometimes when using Git storage removing a token set fails. It seems to be connected to the name of the set, as it's not happening all the time.

https://www.loom.com/share/a383c5d6b04e42b1aede02bd60f91846

@vercel
Copy link

vercel bot commented Sep 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
figma-tokens ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 1:31AM (UTC)
ft-storybook ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 1:31AM (UTC)

@swordEdge swordEdge linked an issue Sep 13, 2022 that may be closed by this pull request
Removing token sets sometimes fails #1275
Closed
@swordEdge swordEdge changed the title bug fix 1275-removing-token-sets-sometimes-fails Sep 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022 •
edited
Loading

Commit SHA:7067ca3c818543af982011a400c6468d7380ea8f
No changes to code coverage between the base branch and the head branch

six7
six7 requested changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@six7 six7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be removing files that I did not remove.

In this commit I only deleted the file Colors/Archive.json - but Base/Colors/Archive.json was deleted as well.

https://github.com/six7/test-repo-ft/commit/5c5d52256923abe2c17e19cf4635e0551f476c71

Can we add tests for this please?

@swordEdge
Copy link
Contributor Author

swordEdge commented Sep 16, 2022 •
edited
Loading

In this commit I only deleted the file Colors/Archive.json - but Base/Colors/Archive.json was deleted as well.
@six7 In my computer it works properly. Could you check this video and again in your computer.
Also added test coverage.
https://www.loom.com/share/a383c5d6b04e42b1aede02bd60f91846

@swordEdge swordEdge requested a review from six7 September 16, 2022 01:29
@six7
Copy link
Collaborator

six7 commented Sep 17, 2022

Great, works now! Merging in

@six7 six7 merged commit 815f57d into next Sep 17, 2022
@SorsOps SorsOps deleted the 1275-removing-token-sets-sometimes-fails branch July 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiamMartens LiamMartens LiamMartens approved these changes

@six7 six7 Awaiting requested review from six7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing token sets sometimes fails
4 participants
@swordEdge @six7 @LiamMartens @robinhoodie0823