-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: URL and JSONbin storage #1172
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@six7 I did notice JSONBin currently always asks to recover local changes (also in the live plugin), We may want to review this behavior - but it's a bit of a weird one because it's the only provider type we automatically sync as opposed to the git providers. Perhaps there is merit in just aligning the logic altogether and also making this a manual action like the git providers? |
Commit SHA:9b334495ac6b8ccd6ae47464831de0a3da3717ff Test coverage results 🧪
|
Commit SHA:25725d216579665ce8788c8478dbd4618903ba2a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agree, we should align as much as we can, making this a manual pull/push action would be great. I'll create an issue |
…ot object (ensure to support incoming)
…sonbin-metadata-and-themes
@six7 I updated the PR to move the version and updatedAt keys to the metadata and remove them from the root object. The root object keys are still supported when reading. |
Updated URL storage provider to support themes and metadata
Updated JSONbin to support metadata
Fixes #1164