Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix with theme name working vs not working #3088

Closed
UdayHyma opened this issue Aug 20, 2024 · 2 comments · Fixed by #3098
Closed

Prefix with theme name working vs not working #3088

UdayHyma opened this issue Aug 20, 2024 · 2 comments · Fixed by #3098
Labels

Comments

@UdayHyma
Copy link
Collaborator

UdayHyma commented Aug 20, 2024

Describe the bug
If I have the dark theme selected but want to export styles for the light theme with the export option Prefix styles with active theme name enabled, the plugin instead exports styles with Ignore first part of token name. It seems to be the case that a user has to select the the set and theme 2x before being able to export it correctly with the Prefix styles with active theme name option enabled.

To Reproduce
Steps to reproduce the behavior:

  1. Have two sets also setup as themes - same theme-group
  2. Select Set B in the plugin's main view
  3. Enable the Prefix styles with active theme name option
  4. Select the appropriate style options
  5. In the themes screen, instead select Set A for export
  6. Export styles
  7. See error

Expected behavior
I don't think the user should have to select the set first then proceed to select the same set again but in the themes screen to export as styles with the Prefix styles with active theme name option enabled. Regardless of which set is selected, the user should be able to export the any theme that is selected in the final export screen.

Screenshots or Screencasts
https://github.com/user-attachments/assets/f63d7980-368f-4e9e-bb41-3ab014dae8ef

Figma file (optional)
Test file

@keeganedwin keeganedwin changed the title Prefix with theme name working vs not working. Prefix with theme name working vs not working Aug 20, 2024
@akshay-gupta7
Copy link
Contributor

@UdayHyma @rbosker @keeganedwin , isn't this consistent with the expected behaviour that only those styles shall be exported when the corresponding set is active:
https://docs.tokens.studio/styles/create-styles

Screenshot 2024-08-21 at 00 26 46

@rbosker
Copy link
Collaborator

rbosker commented Aug 21, 2024

@akshay-gupta7 > that is correct, the difference is that we now have 2 places where we can enable sets: the plugin and the export modal. I expect that if I enable a set in the export view, that just works like the set is active in the plugin view.

@akshay-gupta7 akshay-gupta7 linked a pull request Aug 22, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants