Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for stroke weight and opacity variables #2414

Closed
keeganedwin opened this issue Dec 7, 2023 · 4 comments · Fixed by #2442
Closed

Add support for stroke weight and opacity variables #2414

keeganedwin opened this issue Dec 7, 2023 · 4 comments · Fixed by #2442
Assignees
@six7
Labels
❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma border properties Figma variables plugin v2 variables, UI, WTCG format, Bitbucket token type border composite token type token type color token type dimensions token type number token type opacity

Comments

@keeganedwin
Copy link
Collaborator

keeganedwin commented Dec 7, 2023 •
edited by six7
Loading

Figma recently released new properties to which we can apply variables:

  • Stroke weight
  • Opacity

We should make sure that when users apply a token that has a connected variable, we apply that variable for users.
@six7 six7 changed the title Support For New Variables Add support for stroke weight and opacity variables Dec 27, 2023
@six7 six7 removed their assignment Dec 27, 2023
@six7 six7 moved this from 📥 Triage to 📤 Ready for dev in Tokens Studio for Figma Roadmap Dec 27, 2023
@six7 six7 self-assigned this Dec 28, 2023
@six7 six7 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Dec 28, 2023
@six7 six7 mentioned this issue Dec 28, 2023
Merged
@six7 six7 linked a pull request Dec 28, 2023 that will close this issue
Adds support for stroke weight and opacity variable binding #2442
Merged
six7 added a commit that referenced this issue Dec 28, 2023
@six7
Adds support for stroke weight and opacity variable binding (#2442)
8cfda93 
### Why does this PR exist?

Fixes #2414

Figma recently added support for binding variables to stroke weight and
opacity (among others). This PR adds support for that.

### What does this pull request do?

Integrates our already used `tryApplyVariableId` to the stroke weight
and opacity properties.

### Testing this change

Create a dimension token, right click it and set `border width` to any
of the properties. Make sure that that dimension token exists as a
variable

### Additional Notes (if any)

Merging into `release-139` as the next major release.

<img width="941" alt="CleanShot 2023-12-28 at 01 11 11@2x"
src="https://github.com/tokens-studio/figma-plugin/assets/4548309/4a9812df-f1f9-492f-8011-d261e5070460">
@six7
Copy link
Collaborator

six7 commented Dec 28, 2023

Will be part of 2.0

@six7 six7 closed this as completed Dec 28, 2023
@github-project-automation github-project-automation bot moved this from 🕜 In Progress to ✅ Done in Tokens Studio for Figma Roadmap Dec 28, 2023
@chriskerr-performio
Copy link

@six7 @keeganedwin will 2.0 also cover layout grid and effects elements per the Dec 6 2023 Figma release??

@six7
Copy link
Collaborator

six7 commented Jan 10, 2024

@six7 @keeganedwin will 2.0 also cover layout grid and effects elements per the Dec 6 2023 Figma release??

We aim to support effects and effect styles as well, that one is tracked here: #2443

Layout grids will likely not make it, given we dont support those yet at all (and imo there are more important new token types to tackle)

@keeganedwin keeganedwin mentioned this issue Jan 25, 2024
Closed
@SamIam4Hyma SamIam4Hyma added the ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post label Apr 13, 2024
@SamIam4Hyma
Copy link
Collaborator

Added to Featurebase Roadmap- ❖ 🚧 ❇️ Variables in stroke weight and opacity

@six7 six7 mentioned this issue Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@six7 six7

Labels
❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma border properties Figma variables plugin v2 variables, UI, WTCG format, Bitbucket token type border composite token type token type color token type dimensions token type number token type opacity
Projects
Tokens Studio for Figma Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds support for stroke weight and opacity variable binding tokens-studio/figma-plugin
4 participants
@six7 @keeganedwin @chriskerr-performio @SamIam4Hyma