Fix negative temperatures #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DHT22 supports negative temperatures which weren't read correctly. Fixes #10.
|
Tested in my freezer. |
kasperl
approved these changes
Jan 6, 2025
src/dht11.toit
Outdated
| /** | ||
| Driver for the DHT11 sensor. | ||
|
|
||
| Should also work for compatible sensors like the DHT12, or KY-015. |
There was a problem hiding this comment.
Suggested change
| Should also work for compatible sensors like the DHT12, or KY-015. | |
| Should also work for compatible sensors like the DHT12 or KY-015. |
src/dht22.toit
Outdated
| // second bit to determine which approach the sensor uses. | ||
| byte1 := data[TEMPERATURE_INDEX_] | ||
| temperature10/int := ? | ||
| if (byte1 & 0x80 == 0) or (byte1 & 0x04 == 1): |
There was a problem hiding this comment.
Maybe spell out the range implied by 0x04 constant?
There was a problem hiding this comment.
done and fixed a typo. (It should have been "0x40").
done.
There was a problem hiding this comment.
done and fixed a typo. (It should have been "0x40"). done.
That's kinda what I expected :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DHT22 supports negative temperatures which weren't read correctly.
Fixes #10.