Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificate roots. #48

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Update certificate roots. #48

merged 1 commit into from
Jan 2, 2025

Conversation

floitsch
Copy link
Member

@floitsch floitsch commented Jan 2, 2025

Also add another starfield certificate to the common roots.

Make sure we run the slow test with make test.

Also add another starfield certificate to the common roots.

Make sure we run the slow test with `make test`.
@floitsch floitsch requested a review from kasperl January 2, 2025 11:14
@floitsch
Copy link
Member Author

floitsch commented Jan 2, 2025

TBR.

@floitsch floitsch merged commit 024c8b0 into main Jan 2, 2025
5 checks passed
@floitsch floitsch deleted the floitsch/update branch January 2, 2025 11:15
Copy link
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.


Some APIs also accept a list of root certificates, but installing roots
for the whole process is typically more convenient.
globally is typically more convenient.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really isn't global, is it? It is per process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental change due to this file being generated.
#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants