Retry when getting a 502 from cloudflare #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
approved these changes
Jan 25, 2024
|
|
||
| static create-client_ config/ServerConfigHttp network/net.Interface -> http.Client: | ||
| if config.root-certificate-ders: | ||
| root-certificates := config.root-certificate-ders.map: |
There was a problem hiding this comment.
Maybe we should redoing this if the 502s are quite frequent?
We can easily move the security store and root certificates list construction to the constructor.
There was a problem hiding this comment.
The security-store should absolutely be stored outside, as we would otherwise lose the resume-information.
I kept the root-certificate parsing in here, as I hope that the GC can get rid of the certificates more easily this way.
done.
kasperl
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time in the service.