Use 'yaml' files for pod specifications. #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
approved these changes
Jan 24, 2024
public/docs/fleet/index.mdx
Outdated
| ``` | ||
|
|
||
| If your `fleet.json` uses `my-pod@latest`, you can ask the fleet | ||
| If your `fleet.yaml` uses `my-pod@latest`, you can ask the fleet |
There was a problem hiding this comment.
Is fleet now yaml? I think this is wrong here and in a few more places.
There was a problem hiding this comment.
I think it was only here and in line 372.
done.
src/cli/cmds/pod.toit
Outdated
| // If we only want the non-flattened version read the json by hand. | ||
| json = read-json specification-path | ||
| // If we only want the non-flattened version read the json/yaml again by hand. | ||
| if specification-path.ends-with ".json": |
There was a problem hiding this comment.
Could this use the helper in pod-specification.toit?
| if path.ends-with ".json": | ||
| return read-json path | ||
| if path.ends-with ".yaml" or path.ends-with ".yml": | ||
| return read-yaml path |
There was a problem hiding this comment.
Can the yaml parser read json? We may not want to use that because then we suddenly support reading yaml from .json files, but we could also get away with not caring about the extension at all -- and tell the user if it doesn't contain valid YAML or JSON.
There was a problem hiding this comment.
I slightly prefer to use the json-parser when it's JSON.
can be convinced otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.