Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SDK v2.0.0-alpha.120. #901

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add support for SDK v2.0.0-alpha.120. #901

merged 4 commits into from
Nov 10, 2023

Conversation

kasperl
Copy link
Contributor

@kasperl kasperl commented Nov 10, 2023

No description provided.

@kasperl kasperl requested a review from floitsch November 10, 2023 06:13
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We shouldn't use toit.run to compile snapshots (but use toit.compile instead), and just creating a snapshot this way won't track dependencies, but it should be ok.
I might fix that in a follow-up PR.

@kasperl
Copy link
Contributor Author

kasperl commented Nov 10, 2023

LGTM. We shouldn't use toit.run to compile snapshots (but use toit.compile instead), and just creating a snapshot this way won't track dependencies, but it should be ok. I might fix that in a follow-up PR.

Doesn't really look like this is going to work. The invocation of src/cli/cli.toit also leads to a crap ton of warnings, so we are at a place where we cannot have Artemis working and using deprecated functionality. It kinda sucks. Maybe we need a flag for toit.run and toit.compile to ignore warnings?

@floitsch
Copy link
Member

I think toit.run should emit warnings on stderr.

@kasperl kasperl enabled auto-merge (squash) November 10, 2023 07:55
@kasperl kasperl merged commit 1319f8c into main Nov 10, 2023
@kasperl kasperl deleted the support-alpha.120 branch November 10, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants