Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce resuable helper for periodic check-in functionality. #863

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

kasperl
Copy link
Contributor

@kasperl kasperl commented Oct 3, 2023

No description provided.

@kasperl kasperl requested a review from floitsch October 3, 2023 08:32
$SynchronizeJob, so they can piggyback on an already established
network connection and respect when Artemis is forced offline.
*/
abstract class PeriodicNetworkRequest:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to change the NtpJob to be a periodic request in another PR.

Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/service/periodic-network-request.toit Show resolved Hide resolved
@kasperl kasperl merged commit 1c0d19c into main Oct 3, 2023
@kasperl kasperl deleted the refactor-check-in branch October 3, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants