Add qemu test #827
Add qemu test #827
Conversation
src/cli/cmds/serial.toit
Outdated
| @@ -200,6 +209,16 @@ flash parsed/cli.Parsed config/Config cache/Cache ui/Ui: | |||
| if reference.id: info += "." | |||
| else: info += " ($pod.id)." | |||
| ui.info info | |||
| else if qemu-image: | |||
| if pod.chip != "esp32" and not pod.chip.starts-with "esp32-": | |||
| ui.abort "Cannot write to Qemu image file for chip '$pod.chip'." | |||
There was a problem hiding this comment.
| ui.abort "Cannot write to Qemu image file for chip '$pod.chip'." | |
| ui.abort "Cannot write to QEMU image file for chip '$pod.chip'." |
There was a problem hiding this comment.
You decide if you want to stick with Qemu over QEMU, because it looks like you use Qemu fairly consistenly even though it is called QEMU :)
src/cli/cmds/serial.toit
Outdated
| @@ -93,6 +97,10 @@ create-serial-commands config/Config cache/Cache ui/Ui -> List: | |||
| --short-name="i" | |||
| --short-help="The identity file to use." | |||
| --required, | |||
| cli.Option "qemu-image" | |||
| --type="file" | |||
| --short-help="Write to an Qemu image file instead of flashing." | |||
There was a problem hiding this comment.
| --short-help="Write to an Qemu image file instead of flashing." | |
| --short-help="Write to an QEMU image file instead of flashing." |
tests/qemu-hello-test.toit
Outdated
|
|
||
| HELLO-WORLD-CODE ::= """ | ||
| main: print "hello world" | ||
| """ |
There was a problem hiding this comment.
I would probably dedent this.
tests/qemu-hello-test.toit
Outdated
| provider := esp32.EthernetServiceProvider.mac-openeth | ||
| --phy-chip=esp32.PHY-CHIP-DP83848 | ||
| provider.install | ||
| """ |
There was a problem hiding this comment.
I would probably dedent this.
tests/qemu-hello-test.toit
Outdated
| write-blob-to-file eth-provider-path ETHERNET-PROVIDER-CODE | ||
|
|
||
| print "Creating qemu firmware." | ||
| // Create a firmware. |
There was a problem hiding this comment.
Not sure the comment helps given the printing above.
tests/qemu-hello-test.toit
Outdated
| eth-provider-path := "$fleet-dir/eth-provider.toit" | ||
| write-blob-to-file eth-provider-path ETHERNET-PROVIDER-CODE | ||
|
|
||
| print "Creating qemu firmware." |
There was a problem hiding this comment.
| print "Creating qemu firmware." | |
| print "Creating Qemu firmware." |
tests/utils.toit
Outdated
| @@ -165,6 +169,7 @@ class TestCli: | |||
| cli.main args --config=config --cache=cache --ui=ui | |||
| finally: | is-exception _ | | |||
| if is-exception: | |||
| print "args: $args" | |||
There was a problem hiding this comment.
Drop the debug printing again?
There was a problem hiding this comment.
I think it's actually quite helpful, and it only triggers if things fail.
changed it to be "nicer":
"Execution of '$args' failed unexpectedly."
done.
No description provided.