-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement override triggers. #825
Merged
+127
−19
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3be1f96
Give access to triggers of current container.
floitsch db250ab
Add more information to triggers.
floitsch f37718b
Add 'Triggers' class
floitsch 979b353
Add 'deep-sleep-state' abstraction
floitsch c1bef6b
More refactoring of job states.
floitsch 0a81d74
Implement override triggers.
floitsch 2f6d376
Feedback.
floitsch 2844e92
Feedback.
floitsch 04d6df2
Merge branch 'main' into floitsch/triggers.10.expose
floitsch 89c3700
Merge branch 'floitsch/triggers.10.expose' into floitsch/triggers.20.…
floitsch 756a0d2
Merge branch 'main' into floitsch/triggers.20.more-info
floitsch 4666ba4
Merge branch 'floitsch/triggers.20.more-info' into floitsch/triggers.…
floitsch a57c8d2
Merge branch 'main' into floitsch/triggers.30.triggers-class
floitsch 6b22c1f
Merge branch 'floitsch/triggers.30.triggers-class' into floitsch/trig…
floitsch 24a989d
Merge branch 'main' into floitsch/triggers.30.triggers-class
floitsch 2e85979
Merge branch 'floitsch/triggers.30.triggers-class' into floitsch/trig…
floitsch 3697aed
Merge branch 'main' into floitsch/triggers.40.deep-sleep-state
floitsch 505d54b
Merge branch 'floitsch/triggers.40.deep-sleep-state' into floitsch/tr…
floitsch 7ac2a2b
Feedback.
floitsch d7b65f9
Merge branch 'main' into floitsch/triggers.50.deep-sleep-state2
floitsch d74f558
Merge branch 'floitsch/triggers.50.deep-sleep-state2' into floitsch/t…
floitsch 71f3c90
Merge.
floitsch 78627c0
Feedback.
floitsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure yet, but I feel like I want to couple this with the container restart mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add this functionality, but Consibio wants to be able to disable a pin-trigger. They might not necessarily need to restart at that point.
It's also easier if the program decides at start-up what its next triggers should be. (Or maybe just after connecting...).
If we force a restart when setting the trigger, then it's quite easy to forget it, or to accidentally not set if if the program crashes...