Give access to triggers of current container. #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
approved these changes
Sep 25, 2023
| @@ -9,7 +9,7 @@ interface ArtemisService: | |||
| static SELECTOR ::= ServiceSelector | |||
| --uuid="61d82c0b-7009-4e16-b248-324de4e25f9B" | |||
| --major=0 | |||
| --minor=7 | |||
| --minor=10 // TODO(florian): is this correct? | |||
There was a problem hiding this comment.
No, this can stay 8. It is independent of the Artemis version.
There was a problem hiding this comment.
Completely confused myself about this...
8 now.
done.
src/service/service.toit
Outdated
| @@ -130,6 +139,9 @@ class ArtemisServiceProvider extends ChannelServiceProvider | |||
| container-current-trigger -> int: | |||
| unreachable // Here to satisfy the checker. | |||
|
|
|||
| container-current-triggers -> List: | |||
| unreachable // Here to satisfy the checker. | |||
There was a problem hiding this comment.
Suggested change
| unreachable // Here to satisfy the checker. | |
| unreachable // Here to satisfy the checker. |
| @@ -87,6 +90,9 @@ class ArtemisClient extends ServiceClient | |||
| container-current-trigger -> int: | |||
There was a problem hiding this comment.
Are we going to deprecate this?
There was a problem hiding this comment.
The name is a bit confusing now.
This is the reason the container was started. So it's independent of the triggers.
It could, theoretically, be a list of reasons. Currently we stop keeping track of them once we know that a container needs to be started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.