Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework container start and remember reason #786

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

floitsch
Copy link
Member

No description provided.

@floitsch floitsch requested a review from kasperl August 30, 2023 14:27
Copy link
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

--critical/bool=false
--pin/int?=null
--touch/int?=null:
// These constants must be kept in sync with the ones in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just use the constants from the package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to move the function into the package in a follow-up PR.

@floitsch floitsch merged commit c52f99b into main Aug 31, 2023
@floitsch floitsch deleted the floitsch/trigger-artemis_lib.10.remember branch August 31, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants