Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use '-o' for recovery export. #1140

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Use '-o' for recovery export. #1140

merged 3 commits into from
Jun 28, 2024

Conversation

floitsch
Copy link
Member

No description provided.

floitsch added 2 commits June 28, 2024 10:06

Verified

This commit was signed with the committer’s verified signature.
liamhuber Liam Huber
@floitsch floitsch requested a review from kasperl June 28, 2024 08:09
# [fleet, recovery, export, --directory, TMP_DIR]
Exported recovery information to 'TMP_DIR/recover--={|~~~~~~~~~~FLEET_ID~~~~~~~~~~|}=-.json'.
# [fleet, recovery, export, -o, TMP_DIR/recovery.json]
Exported recovery information to 'TMP_DIR/recovery.json'.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discrepancy between the output-file name (recovery.json) and the server URL (3 lines down) is OK. We have set the recovery URLs previously to just use recover.json.

Copy link
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floitsch floitsch merged commit 5b23fbd into main Jun 28, 2024
13 checks passed
@floitsch floitsch deleted the floitsch/recovery-o branch June 28, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants