Use 'cert.install' instead of passing in root certificates. #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
reviewed
Jun 20, 2024
| x509.Certificate.parse it | ||
| config_.root-certificate-ders.do: | ||
| certificate := tls.RootCertificate it | ||
| certificate.install |
There was a problem hiding this comment.
Can we do this early when setting up the config instead? There is no hash for this one (I think), so we're going to parse it every single time.
There was a problem hiding this comment.
It's hard to do this earlier, as the Broker is constructed relatively early, but we don't want to spend time installing roots if they won't be needed.
I added a flag that keeps track of whether they are already installed or not.
src/cli/utils/utils.toit
Outdated
| @@ -108,9 +108,9 @@ download-url url/string --out-path/string --ui/Ui -> none: | |||
| ui.info "Downloading $url." | |||
|
|
|||
| network := net.open | |||
| certificate-roots.install-all-trusted-roots | |||
There was a problem hiding this comment.
I kinda want to this a bit earlier. That's typically how we deal with installed certificates.
src/cli/brokers/http/base.toit
Outdated
| @@ -28,6 +28,8 @@ class BrokerCliHttp implements BrokerCli: | |||
| client_/http.Client? := null | |||
|
|
|||
| constructor .server-config_ --.id: | |||
| // We are on the host. Just install all certificate roots. | |||
Co-authored-by: Kasper Lund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.