Fix device config storage with ints #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We wouldn't recognize the stored 8 and return the default 4 all the
time.
The json-decoder always uses a 64-bit float which is what the function
was written for. However, the config file stores the value as integer,
and we would thus ignore that value.
Fixes `jag simulate` without host-name, since that one typically has 8
bytes for a word.
kasperl
approved these changes
Nov 13, 2024
|
I'm not 100% sure what changed. Maybe we stored it as a JSON, or we had better unmarshalling code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wouldn't recognize the stored 8 and return the default 4 all the time.
The json-decoder always uses a 64-bit float which is what the function was written for. However, the config file stores the value as integer,
and we would thus ignore that value.
Fixes
jag simulatewithout host-name, since that one typically has 8 bytes for a word.