Refactor flash and update to share more code. #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floitsch
commented
Oct 28, 2024
| Short: "Update the firmware on a Jaguar device", | ||
| Long: "Update the firmware on a Jaguar device via WiFi. The device name and\n" + | ||
| "id are preserved across the operation.", | ||
| Use: "update [envelope]", |
There was a problem hiding this comment.
Pretty much no change in this file, except that the shared code has been moved out and the areas I added a comment to (in the PR).
| cmd.Flags().MarkHidden("uart-endpoint-rx") | ||
| cmd.Flags().Uint("uart-endpoint-baud", 0, "set the baud rate for the UART endpoint") | ||
| cmd.Flags().MarkHidden("uart-endpoint-baud") | ||
| addFirmwareFlashFlags(cmd, "", "new name of the device, if given") |
There was a problem hiding this comment.
We now have the option of changing the name.
| "id are preserved across the operation.", | ||
| Use: "update [envelope]", | ||
| Short: "Update the firmware on a Jaguar device", | ||
| Long: "Update the firmware on a Jaguar device via WiFi", |
There was a problem hiding this comment.
I updated the help, since the ID was already changing, and we now have a way to change the name.
| } | ||
|
|
||
| func withFirmware(cmd *cobra.Command, args []string, device Device, fun callback) error { | ||
| ctx := cmd.Context() |
There was a problem hiding this comment.
All of this code was copied out from firmware.go and flash.go.
| if device != nil { | ||
| chip = device.Chip() | ||
| } else { | ||
| return fmt.Errorf("chip type must be specified") |
There was a problem hiding this comment.
Minor change here: the old flash command had the message "auto isn't implemented yet".
| return fun(id.String(), envelopeFile, config) | ||
| } | ||
|
|
||
| func BuildFirmwareEnvelope(ctx context.Context, envelope EnvelopeOptions, device DeviceOptions, uartEndpointOptions map[string]interface{}) (*os.File, error) { |
There was a problem hiding this comment.
Anything below this line is copied verbatim without any change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.