Fix crash and provide better error when chip is wrong. #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yudistrange
reviewed
Sep 23, 2024
Comment on lines
-44
to
+59
| defer bundle.Close() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| defer bundle.Close() |
There was a problem hiding this comment.
Uh.. this seems unrelated, right?
Also (I'm not an expert at golang so please correct me) can deferring after the err != nil check lead to bundle not being closed because in case of an error the program will return before the defer is set?
There was a problem hiding this comment.
The thinking is that if err == nil, then bundle will be nil or at least not open. If bundle is nil, then calling bundle.Close (even deferred) will cause a crash.
kasperl
approved these changes
Sep 24, 2024
Comment on lines
-44
to
+59
| defer bundle.Close() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| defer bundle.Close() |
There was a problem hiding this comment.
The thinking is that if err == nil, then bundle will be nil or at least not open. If bundle is nil, then calling bundle.Close (even deferred) will cause a crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #558