Skip to content

Commit

Permalink
Change default for TENV_DETACHED_PROXY on non windows OS #255 (#304)
Browse files Browse the repository at this point in the history
Signed-off-by: Denis Vaumoron <[email protected]>
  • Loading branch information
dvaumoron authored Dec 22, 2024
1 parent e847d35 commit f665b6e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -639,9 +639,9 @@ If set to true **tenv** will automatically install missing tool versions needed.

<details><summary><b>TENV_DETACHED_PROXY</b></summary><br>

String (Default: false)
String (Default: false on Windows OS, true on other OS)

Enable **tenv** proxies detached behaviour (use a new process group id when launching tool command, allow to avoid killing proxied tool process earlier than expected when proxies redirect interrupt signal already sended to whole process group (issue occurrences known on macOS)).
Enable **tenv** proxies detached behaviour (use a new process group id when launching tool command, allow to avoid killing proxied tool process earlier than expected when proxies redirect interrupt signal already sended to whole process group (issue occurrences known on macOS and Linux)).

</details>

Expand Down
2 changes: 1 addition & 1 deletion versionmanager/proxy/detach/detached_others.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (
const msgErr = "Failed to read " + config.TenvDetachedProxyEnvName + " environment variable, disable behavior :"

func InitBehaviorFromEnv(cmd *exec.Cmd, getenv configutils.GetenvFunc) {
detached, err := getenv.Bool(false, config.TenvDetachedProxyEnvName)
detached, err := getenv.Bool(true, config.TenvDetachedProxyEnvName)
if err != nil {
fmt.Println(msgErr, err) //nolint
}
Expand Down

0 comments on commit f665b6e

Please sign in to comment.