Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add higher kinded typeclass instances for Logs #191

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Add higher kinded typeclass instances for Logs #191

merged 3 commits into from
Mar 10, 2020

Conversation

catostrophe
Copy link
Member

  1. Removed the Embed[Logging] instance overlapped by the RepresentableK[Logging] instance and thus unsummonable.
  2. Added MonoidalK instances for Logs for the second type param.

@Odomontois Odomontois added fix enhancement New feature or request labels Mar 10, 2020
@Odomontois Odomontois merged commit cabaa4b into tofu-tf:master Mar 10, 2020
@catostrophe catostrophe deleted the logs-instances branch March 25, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Odomontois Odomontois Odomontois approved these changes

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@eld0727 eld0727 Awaiting requested review from eld0727

@Z1kkurat Z1kkurat Awaiting requested review from Z1kkurat

Assignees
No one assigned
Labels
enhancement New feature or request fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catostrophe @Odomontois