Zio2 logging: tests + documentation #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagroz
requested review from
Odomontois,
danslapman,
catostrophe,
FunFunFine and
oskin1
as code owners
vagroz
force-pushed
the
zio2_logging_test
branch
2 times, most recently
from
c3bba12 to
d59e985
Compare
vagroz
force-pushed
the
zio2_logging_test
branch
from
d59e985 to
1a8d6c3
Compare
FunFunFine
reviewed
Dec 21, 2022
|
|
||
| object ZLogsSpec extends ZIOSpecDefault { | ||
|
|
||
| val loggerName: String = this.getClass.getName.replace("$", "") |
There was a problem hiding this comment.
case object ZLogsSpec & this.productPrefix
There was a problem hiding this comment.
this should be with package prefix
FunFunFine
reviewed
Dec 21, 2022
FunFunFine
reviewed
Dec 21, 2022
|
It'd be nice to have the same "recipe" for ZLogs as for the other logging approaches . It will both illustrate the intended way and will allow people to look at this as a whole thing with wiring and stuff. It'd be fine if it comes in another PR though |
FunFunFine
approved these changes
Dec 21, 2022
vagroz
force-pushed
the
zio2_logging_test
branch
from
d9ad354 to
4dc20b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.