Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIO-2 logging (Part 1) #1038
ZIO-2 logging (Part 1) #1038
Changes from 1 commit
59a0fcf
e1b4bd7
86303db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any other way to get implement this method other than that? It feels like any implementation of
ContextProvider
will be doingsomething.something.map(x => /*implicit conversion*/ x)
. Perhaps it's better to make itContextProvider[A: Loggable]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZLogs.layerPlainWithContext
is pretty now: we can provide to it any implementation ofContextProvider
.If we make this trait as
ContextProvider[A: Loggable]
, the layer will also require type-parameter which can be huge enough. For example, next PR will bringContextProvider
with dataA = Map[ZLogAnnotation[_], Any]
.As a user, I don't want write THIS type
A
, ideally I should not know anything about it. I just write two thingsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest
abstract class ValueContextProvider
which do this itselfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that'll work