Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): prevent auto focus in mobile modal #9247

Merged

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Dec 23, 2024

Continue BS-2169

Copy link
Contributor Author

L-Sun commented Dec 23, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@L-Sun L-Sun marked this pull request as ready for review December 23, 2024 05:43
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (ba355d0) to head (067469a).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/frontend/component/src/ui/modal/modal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #9247   +/-   ##
=======================================
  Coverage   51.85%   51.85%           
=======================================
  Files        2136     2136           
  Lines       97259    97261    +2     
  Branches    16629    16630    +1     
=======================================
+ Hits        50435    50437    +2     
+ Misses      45458    45457    -1     
- Partials     1366     1367    +1     
Flag Coverage Δ
server-test 78.26% <ø> (ø)
unittest 30.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun force-pushed the l-sun/fix/prevent-auto-focus-for-in-mobile-modal branch from 94b9519 to f444211 Compare December 23, 2024 06:01
@L-Sun L-Sun force-pushed the l-sun/fix/prevent-auto-focus-for-in-mobile-modal branch from f444211 to 6cec5a0 Compare December 23, 2024 06:40
@L-Sun L-Sun requested a review from EYHN December 23, 2024 07:00
Copy link

graphite-app bot commented Dec 23, 2024

Merge activity

@L-Sun L-Sun force-pushed the l-sun/fix/prevent-auto-focus-for-in-mobile-modal branch from 6cec5a0 to 067469a Compare December 23, 2024 09:57
@graphite-app graphite-app bot merged commit 067469a into canary Dec 23, 2024
60 checks passed
@graphite-app graphite-app bot deleted the l-sun/fix/prevent-auto-focus-for-in-mobile-modal branch December 23, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants