Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): quotaCheck dialog should not appear in team workspace #9223

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 20, 2024

CleanShot 2024-12-20 at 16 37 17@2x

@JimmFly JimmFly marked this pull request as ready for review December 20, 2024 08:37
@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Dec 20, 2024
Copy link
Member Author

JimmFly commented Dec 20, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JimmFly JimmFly changed the title fix(core): QuotaCheck dialog should not appear in team workspace fix(core): quotaCheck dialog should not appear in team workspace Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.83%. Comparing base (02aeb89) to head (c793f23).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9223      +/-   ##
==========================================
- Coverage   51.83%   51.83%   -0.01%     
==========================================
  Files        2136     2136              
  Lines       97264    97264              
  Branches    16630    16630              
==========================================
- Hits        50414    50412       -2     
- Misses      45489    45491       +2     
  Partials     1361     1361              
Flag Coverage Δ
server-test 78.26% <ø> (ø)
unittest 30.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/1220/fix-dialog branch from 8116a4c to c47d5fa Compare December 23, 2024 06:12
Copy link

graphite-app bot commented Dec 23, 2024

Merge activity

@JimmFly JimmFly force-pushed the jimmfly/1220/fix-dialog branch from c47d5fa to c793f23 Compare December 23, 2024 08:52
@graphite-app graphite-app bot merged commit c793f23 into canary Dec 23, 2024
60 checks passed
@graphite-app graphite-app bot deleted the jimmfly/1220/fix-dialog branch December 23, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants