Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): redudant drop target register #9177

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 16, 2024

fix the following issue.
root cause is that options.element is being reused when cleaning up, but if its value comes from a ref, it might be null at that point.

image.png

Copy link
Collaborator Author

pengx17 commented Dec 16, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review December 16, 2024 09:26
@graphite-app graphite-app bot requested review from forehalo, EYHN, CatsJuice and JimmFly and removed request for EYHN December 16, 2024 09:26
@pengx17 pengx17 force-pushed the xp/12-16-fix_core_redudant_drop_target_register branch from aeb4204 to ec46730 Compare December 16, 2024 09:27
@pengx17 pengx17 requested a review from EYHN December 16, 2024 09:28
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.46%. Comparing base (2f79104) to head (7b03875).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...kages/frontend/component/src/ui/dnd/drop-target.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9177      +/-   ##
==========================================
- Coverage   65.47%   65.46%   -0.01%     
==========================================
  Files         721      721              
  Lines       41157    41160       +3     
  Branches     4032     4033       +1     
==========================================
- Hits        26947    26945       -2     
- Misses      13781    13786       +5     
  Partials      429      429              
Flag Coverage Δ
server-test 77.80% <ø> (ø)
unittest 35.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix the following issue.
root cause is that options.element is being reused when cleaning up, but if its value comes from a ref, it might be null at that point.

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/1739c4e0-9ba8-4e27-8944-c6022644b40d.png)
@pengx17 pengx17 force-pushed the xp/12-16-fix_core_redudant_drop_target_register branch from ec46730 to 7b03875 Compare December 16, 2024 10:23
Copy link

graphite-app bot commented Dec 16, 2024

Merge activity

@graphite-app graphite-app bot merged commit 7b03875 into canary Dec 16, 2024
47 checks passed
@graphite-app graphite-app bot deleted the xp/12-16-fix_core_redudant_drop_target_register branch December 16, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants