Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): show page back by url search #9100

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Dec 11, 2024

close AF-1911

Copy link

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Dec 11, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CatsJuice CatsJuice marked this pull request as ready for review December 11, 2024 05:56
Copy link

nx-cloud bot commented Dec 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5dd2ddd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.41%. Comparing base (84df2a1) to head (5dd2ddd).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #9100   +/-   ##
=======================================
  Coverage   65.41%   65.41%           
=======================================
  Files         715      715           
  Lines       41122    41122           
  Branches     3983     3983           
=======================================
+ Hits        26898    26900    +2     
+ Misses      13800    13798    -2     
  Partials      424      424           
Flag Coverage Δ
server-test 77.42% <ø> (ø)
unittest 35.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-doc-back branch from e17ca17 to 12845c5 Compare December 11, 2024 06:17
@github-actions github-actions bot added the test Related to test cases label Dec 11, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-doc-back branch 4 times, most recently from 01b4bfa to d5990e1 Compare December 11, 2024 09:00
@CatsJuice CatsJuice requested a review from EYHN December 11, 2024 09:00
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-doc-back branch from d5990e1 to 53d9fdc Compare December 11, 2024 09:22
Copy link

graphite-app bot commented Dec 12, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/feat/mobile-doc-back branch from 53d9fdc to 5dd2ddd Compare December 12, 2024 07:14
@graphite-app graphite-app bot merged commit 5dd2ddd into canary Dec 12, 2024
47 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/mobile-doc-back branch December 12, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants