Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): optimize upgrade to team page #9099

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 11, 2024

close AF-1922 AF-1919

fix(core): add confirm modal to remove member

fix(core): add login detection to upgrade-to-team page

fix(core): add selected recurring to upgrade-to-team page

fix(core): cancel and resume team subscription

Copy link

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Dec 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JimmFly JimmFly changed the title fix(core): add confirm modal to remove member fix(core): team workspace Dec 11, 2024
@JimmFly JimmFly changed the title fix(core): team workspace fix(core): optimize upgrade to team Dec 11, 2024
@JimmFly JimmFly changed the title fix(core): optimize upgrade to team fix(core): optimize upgrade to team page Dec 11, 2024
@JimmFly JimmFly marked this pull request as ready for review December 11, 2024 03:34
Copy link

nx-cloud bot commented Dec 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e368f17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.33%. Comparing base (eee0ed4) to head (e368f17).
Report is 5 commits behind head on canary.

Files with missing lines Patch % Lines
...c/modules/cloud/entities/workspace-subscription.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9099      +/-   ##
==========================================
- Coverage   65.93%   65.33%   -0.60%     
==========================================
  Files         713      714       +1     
  Lines       40915    41046     +131     
  Branches     3986     3973      -13     
==========================================
- Hits        26977    26818     -159     
- Misses      13520    13803     +283     
- Partials      418      425       +7     
Flag Coverage Δ
server-test 77.30% <ø> (-0.71%) ⬇️
unittest 35.99% <0.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/1211/fix-team branch from bfd4eb0 to 9321845 Compare December 11, 2024 08:05
@JimmFly JimmFly force-pushed the jimmfly/1211/fix-team branch from 9321845 to e368f17 Compare December 11, 2024 08:14
@forehalo forehalo merged commit 4eb3144 into canary Dec 11, 2024
47 checks passed
@forehalo forehalo deleted the jimmfly/1211/fix-team branch December 11, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants