feat(core): allow bs snapshot dragging targets #9093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dc7d128. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #9093 +/- ##
==========================================
- Coverage 65.38% 65.37% -0.01%
==========================================
Files 714 715 +1
Lines 41046 41052 +6
Branches 3973 3976 +3
==========================================
Hits 26838 26838
- Misses 13783 13789 +6
Partials 425 425
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pengx17
force-pushed
the
12-10-feat_core_allow_bs_snapshot_dragging_targets
branch
2 times, most recently
from
be71751 to
3f0ec76
Compare
graphite-app
bot
requested review from
forehalo,
EYHN,
CatsJuice and
JimmFly
and removed request for
forehalo
pengx17
force-pushed
the
12-10-feat_core_allow_bs_snapshot_dragging_targets
branch
from
3f0ec76 to
6863e9b
Compare
pengx17
force-pushed
the
12-10-feat_core_allow_bs_snapshot_dragging_targets
branch
6 times, most recently
from
3168f61 to
a4d611f
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/frontend/apps/electron/src/main/windows-manager/tab-views.ts
Outdated
Show resolved
Hide resolved
pengx17
force-pushed
the
12-10-feat_core_allow_bs_snapshot_dragging_targets
branch
from
a4d611f to
ffc8ee4
Compare
EYHN
reviewed
Dec 11, 2024
EYHN
approved these changes
Dec 11, 2024
pengx17
force-pushed
the
12-10-feat_core_allow_bs_snapshot_dragging_targets
branch
from
ffc8ee4 to
1ac8913
Compare
Merge activity
|
fix AF-1924, AF-1848, AF-1928, AF-1931 dnd between affine & editor <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/dff3ceb1-dc82-4222-9b55-13be80b28b2f.mp4"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/dff3ceb1-dc82-4222-9b55-13be80b28b2f.mp4"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/dff3ceb1-dc82-4222-9b55-13be80b28b2f.mp4">20241210-1217-49.8960381.mp4</video>
pengx17
force-pushed
the
12-10-feat_core_allow_bs_snapshot_dragging_targets
branch
from
1ac8913 to
dc7d128
Compare
graphite-app
bot
deleted the
12-10-feat_core_allow_bs_snapshot_dragging_targets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix AF-1924, AF-1848, AF-1928, AF-1931
dnd between affine & editor